bug - USPS & admin/edit_orders.php

[wkdwich]

running 2.0.25

enabled usps shipping module and on the front end is working properly.

When I went to edit an order today, I got a blank page. I enabled error logging

  // Include currencies class
  require(DIR_WS_CLASSES . 'currencies.php');
  $currencies = new currencies();

error_reporting(E_ALL);
ini_set('error_log', DIR_WS_INCLUDES . mystuff_errors.log');

This returned me with:

Notice: Undefined property: GlobalTest in /home/mystuff/public_html/catalog/includes/modules/shipping/usps.php on line 31

Notice: Use of undefined constant MODULE_SHIPPING_USPS_INSURE - assumed 'MODULE_SHIPPING_USPS_INSURE' in /home/mystuff/public_html/catalog/includes/modules/shipping/usps.php on line 113

Fatal error: Call to undefined function: tep_round_up() in /home/mystuff/public_html/catalog/includes/modules/shipping/usps.php on line 162

I verified the bug in my dev cart. That cart USPS was not installed, edit orders comes up properly. I installed & enabled USPS and edit orders gave me a blank page. I then disabled but did not uninstall USPS and edit orders comes up properly.

How do I repair this?

[ridexbuilder]

This looks like the likely culprit:

       /* 
    THE FOLLOWING FUNCTION CAUSES A 500 ERROR WHEN USING PAYPAL EXPRESS 
    function round_up($valueIn, $places=0) { 
        if ($places < 0) { $places = 0; } 
        $mult = pow(10, $places); 
        return (ceil($valueIn * $mult) / $mult); 
        } 
    */ 
  

[wkdwich]

EJ, I'm not using paypal express.. just the regular paypal IPN module

[ridexbuilder]

Didn't say you were.
Try removing the /* and */

[wkdwich]

That did not work:

Notice: Undefined property: GlobalTest in /home/wkdwich/public_html/shoppe/includes/modules/shipping/usps.php on line 31

Notice: Use of undefined constant MODULE_SHIPPING_USPS_INSURE - assumed 'MODULE_SHIPPING_USPS_INSURE' in /home/wkdwich/public_html/shoppe/includes/modules/shipping/usps.php on line 113

Fatal error: Call to undefined function: tep_round_up() in /home/wkdwich/public_html/shoppe/includes/modules/shipping/usps.php on line 162

[michael_s]

these are just notices and can be ignored:

Notice: Undefined property: GlobalTest in /home/wkdwich/public_html/shoppe/includes/modules/shipping/usps.php on line 31

Notice: Use of undefined constant MODULE_SHIPPING_USPS_INSURE - assumed 'MODULE_SHIPPING_USPS_INSURE' in /home/wkdwich/public_html/shoppe/includes/modules/shipping/usps.php on line 113

You should turn off notices in osCmax, application top.php to stop them from displaying. In v2.0.25 notices are Off by default, so make sure you don't turn them back on.

This one means you are missing a function somewhere:

Fatal error: Call to undefined function: tep_round_up() in /home/wkdwich/public_html/shoppe/includes/modules/shipping/usps.php on line 162

The function tep_round_up is found in /includes/functions/general.php. You should be able to resolve this issue by copying that function to the /admin/includes/functions/general.php.

This is the function you need to add:

 ////
// Round up function for non whole numbers by GREG DEETH
// The value for the precision variable determines how many digits after the decimal and rounds the last digit up to the next value
// Precision = 0 -> xx.xxxx = x+
// Precision = 1 -> xx.xxxx = xx.+
// Precision = 2 -> xx.xxxx = xx.x+
  function tep_round_up($number, $precision) {
    $number_whole = '';
    $num_left_dec = 0;
    $num_right_dec = 0;
    $num_digits = strlen($number);
    $number_out = '';
    $i = 0;
    while ($i + 1 <= strlen($number))
    {
        $current_digit = substr($number, $i, ($i + 1) - $num_digits);
        if ($current_digit == '.') {
            $i = $num_digits + 1;
            $num_left_dec = strlen($number_whole);
            $num_right_dec = ($num_left_dec + 1) - $num_digits;
        } else {
            $number_whole = $number_whole . $current_digit;
            $i = $i + 1;
        }
    }
    if ($num_digits > 3 && $precision < ($num_digits - $num_left_dec - 1) && $precision >= 0) {
        $i = $precision;
        $addable = 1;
        while ($i > 0) {
            $addable = $addable * .1;
            $i = $i - 1;
        } 
        $number_out = substr($number, 0, $num_right_dec + $precision) + $addable;
    } else {
        $number_out = $number;
    }
    return $number_out;
  } 
  

Let me know if that resolves it for you.

[wkdwich]

That did the trick Michael.. thanks edit orders now works dandy.. but grrrrrrr. now my usps module is totally broke.. does the bleeding ever stop???

[wkdwich]

Michael,
much back and forth, testing even calling USPS, removed the module 100% - deleted it from the server.. reinstalled, tested with no setting changes except the USPS user & password info.. it worked, one by one I set the options, each time testing.. when I can down to
Display Transit Time (default is CHECKED)
and unCHECKED it, thats when the communication stopped between the cart and USPS servers. I tested this on the dev cart and the same thing happened.

I doubt severly the adding of the rounding call to the admin/includes/functions/general.php had any bearing but just for good measure I removed it and tried again and it had no effect.. should I revise the bug report, with adding the rounding call or will you do that? And this other issue, make a new bug report??

[michael_s]

If you can reproduce the second problem then submit two separate bug reports as they are two separate issues with the usps module.

Also, you may want to check for updates to the usps module and read any/all documentation with the usps module (at addons.oscommerce.com) as the options may have specific configurations/edits that are required in the module code.

[wkdwich]

ok I will check the docs on the module and submit the 2nd bug. I did verify it in my dev cart