AABOX Max 1.5 and authorize.net / curl possible bug

[djtodd]

AABOX Max 1.5 seems to have a small bug.

This applies mainly to people NOT USING AUTHORIZE.NET, but

After installing 1.5 and playing with it for a while I noticed that somethinig was causing the server cpu to peg out at 100% for some time.

The process turned out to be curl eating up the cpu.

I tracked the problem down in checkout_process.php.

Using the default installation of 1.5 check out line 53 of checkout_process.php

  //************************************************************
  // Authorizenet ADC Direct Connection
  // Make sure the /catalog/includes/class/order.php is included
  // and $order object is created before this!!!
  if(MODULE_PAYMENT_AUTHORIZENET_STATUS) {
   include(DIR_WS_MODULES . 'authorizenet_direct.php');
  }
  //************************************************************

Basically it's calling the authorize.net modulke regardless of whether or not it's enabled. It should read...

  //************************************************************
  // Authorizenet ADC Direct Connection
  // Make sure the /catalog/includes/class/order.php is included
  // and $order object is created before this!!!
  if(MODULE_PAYMENT_AUTHORIZENET_STATUS == "True") {
   include(DIR_WS_MODULES . 'authorizenet_direct.php');
  }
  //************************************************************

If a site IS using authorize.net this won't cause a problem, but if it you aren't it will call curl with arguments like "MODULE_PAYMENT_AUTHORIZE_LOGIN" etc instead of the correct parameters.

This solved my problems, hopefully it can help others avoid this small bug.

By the way, I'd just like to say thank you to all the people who make oscommerce and aabox's version possible. Your hard work is greatly appreciated.

Enjoy,
Josh Todd
Inquis Technologies, LLC
http://www.inquistech.com

[michael_s]

Josh,

Thank you for this fix. I have been so busy I just forgot to reply! I have incorporated this bugfix into MS2-MAX 1.5.2 as of 11/4/2003.

For those of you who do not use AuthorizeNet, this fix is really essential for keeping server loads normal. I suggesst adding the code right away.

For AuthorizeNet users, this fix will not affect you, but you should still add it.

[ChrissieB]

I presume that the sticky 'low order fee' bug fix got taken out of the download version when this bug got fixed? I'm guessing that the complete code snippet needs to read as follows?

  

  require(DIR_WS_CLASSES . 'order.php');
  $order = new order;

  require(DIR_WS_CLASSES . 'order_total.php');
  $order_total_modules = new order_total;

  $order_totals = $order_total_modules->process();

  //************************************************************
  // Authorizenet ADC Direct Connection
  // Make sure the /catalog/includes/class/order.php is included
  // and $order object is created before this!!!
  if(MODULE_PAYMENT_AUTHORIZENET_STATUS == "True") {
   include(DIR_WS_MODULES . 'authorizenet_direct.php');
  }
  //************************************************************

// load the before_process function from the payment modules
  $payment_modules->before_process();

Thanks to everybody involved for their work though - saved me bucketloads of blood sweat and tears![/quote]