RC4 - SEO URLs disabled - endless loop

[mfleeson]

Hi
I'm currently experimenting with RC4 and hit an interesting issue. Whilst I'm setting up I turned off seo-cache however everytime I clicked on a product it went into an endless loop of redirects. I ended up using wget to track down the problem, the browser just went into endless 301 redirects.

I took a look at the SEO config and it showed Redirect = true, whilst enable SEO = false, so it shouldnt have been redirecting.

I turned redirect off and everything sorted itself.

I looked at the code seo.class.php and found:

if ($this->attributes['USE_SEO_CACHE_GLOBAL'] == 'true'){
$this->cache_file = 'seo_urls_v2_';
$this->cache_gc();
if ( $this->attributes['USE_SEO_CACHE_PRODUCTS'] == 'true' ) $this->generate_products_cache();
if ( $this->attributes['USE_SEO_CACHE_CATEGORIES'] == 'true' ) $this->generate_categories_cache();
if ( $this->attributes['USE_SEO_CACHE_MANUFACTURERS'] == 'true' ) $this->generate_manufacturers_cache();
if ( $this->attributes['USE_SEO_CACHE_ARTICLES'] == 'true' && defined('TABLE_ARTICLES_DESCRIPTION')) $this->generate_articles_cache();
if ( $this->attributes['USE_SEO_CACHE_TOPICS'] == 'true' && defined('TABLE_TOPICS_DESCRIPTION')) $this->generate_topics_cache();
if ( $this->attributes['USE_SEO_CACHE_INFO_PAGES'] == 'true' && defined('TABLE_INFORMATION')) $this->generate_information_cache();
} # end if

if ($this->attributes['USE_SEO_REDIRECT'] == 'true'){
$this->check_redirect();
} # end if

Now I might be wrong but shouldnt


**** if ($this->attributes['USE_SEO_REDIRECT'] == 'true'){
$this->check_redirect();
} # end if
*****

be moved inside the above block so it is positioned below the line
defined('TABLE_INFORMATION')) $this->generate_information_cache();

Wasnt sure if this was a bug or me misunderstanding so thought I'd post here before bugtracking it.

p.s. Any idea when RC4 will be approved for basic production use?

Best Wishes

Mark

[michael_s]

Not a bug. You forgot to remove the rewrite rules in .htaccess file. Comment them out and your problem goes away.

RC4 still has some other real bugs that need to be fixed before full release, but it is already being commonly used in production without issues by those that are skilled enough to work around or correct the small issues themselves. There are a lot of smaller issues that add up to a headache for most users though.