Free Shipping Coupon and LinkPoint

[driwashsolutions]

I'm trying to use a free shipping coupon in my store. I'm usin the linkpoint gateway, which required that the subtotal, shipping and total match. So, if any discounts are applied (such as a free shipping coupon) these don't add up as far as linkpoint is concerned.

So, I though I would take the free shipping off before the order is subtotaled, then everything would jive. I've done this through the order total module sort order.

Well, the subtotal is not removing the free shipping amount, so the values still don't jive.

What can I do to get this to work?

[driwashsolutions]

OK figured out the problem for us Linkpoint users.

First, there is a piece of code missing from the catalog/includes/modules/order_total/ot_coupon.php file. Find the this section of code:

function process() {
global $PHP_SELF, $order, $currencies;


	$order_total=$this->get_order_total();
	$od_amount = $this->calculate_credit($order_total);
	$tod_amount = 0.0; //Fred
	$this->deduction = $od_amount;
	if ($this->calculate_tax != 'None') { //Fred - changed from 'none' to 'None'!
		$tod_amount = $this->calculate_tax_deduction($order_total, $this->deduction, $this->calculate_tax);
	}

	if ($od_amount > 0) {
		$order->info['total'] = $order->info['total'] - $od_amount;

Then, add this just below it:

$_SESSION['od_amount'] = $od_amount;

This will then allow this piece of code which already exists in the catalog/includes/modules/order_total/ot_subtotal.php file to work correctly:

    function process() {
      global $order, $currencies;

// BOF: LINES ADDED
      $od_amount = $_SESSION['od_amount'];
      $subtotal = $order->info['subtotal'] - $od_amount;
      $order->info['subtotal'] = $order->info['subtotal'] - $od_amount;
// EOF: LINES ADDED

Finally, change the sort order of the order total modules to put the Discount Coupons BEFORE the subtotal module, and everything will then work out. Here's how it looks in my store:



Now, I'm not a proficient PHP programmer, but there are sections of code that have the $_SESSION line commented out with a statement that says to use the global variable rather than the $_SESSION statement. So if there's a better, more preferred method of getting the $od_amount into the ot_subtotal routine, I would certainly welcome the tip.

John

[red_fraggle]

actually you didnt figure this out, lol, its in the installation instructions i wrote and included with the module and which micheal has included in the module directory for you in the /includes/linkpoint directory.

this is plainly documented, it is required ONLY if you use this module or the credit class gift voucher modification.

linkpoint was originally written for stock oscommerce which did not come with these modules and therefore the code had to be changed IF and only IF you actually added these modules to your store. Since these modules come with oscmax, it needs to be done.

[BadDog]

Originally Posted by driwashsolutions

OK figured out the problem for us Linkpoint users.

Finally, change the sort order of the order total modules to put the Discount Coupons BEFORE the subtotal module, and everything will then work out.
John

Can you be more specific about what files are changed and how in order to change the sort order of the order total modules? I don't want to screw it up.

[BadDog]

Originally Posted by red_fraggle

actually you didnt figure this out, lol, its in the installation instructions i wrote and included with the module and which micheal has included in the module directory for you in the /includes/linkpoint directory.

this is plainly documented, it is required ONLY if you use this module or the credit class gift voucher modification.

linkpoint was originally written for stock oscommerce which did not come with these modules and therefore the code had to be changed IF and only IF you actually added these modules to your store. Since these modules come with oscmax, it needs to be done.

I cannot find the file credit_voucher_gift_card_hack.txt mentioned in the install instructions. Can anyone poiint me in the right direction? I'm trying to make a mod called ccgv(trad) for osCommerce work with Linkpoint. Thanks.

[michael_s]

Originally Posted by driwashsolutions

OK figured out the problem for us Linkpoint users.

First, there is a piece of code missing from the catalog/includes/modules/order_total/ot_coupon.php file. Find the this section of code:

function process() {
global $PHP_SELF, $order, $currencies;


    $order_total=$this->get_order_total();
    $od_amount = $this->calculate_credit($order_total);
    $tod_amount = 0.0; //Fred
    $this->deduction = $od_amount;
    if ($this->calculate_tax != 'None') { //Fred - changed from 'none' to 'None'!
        $tod_amount = $this->calculate_tax_deduction($order_total, $this->deduction, $this->calculate_tax);
    }

    if ($od_amount > 0) {
        $order->info['total'] = $order->info['total'] - $od_amount;

Then, add this just below it:

$_SESSION['od_amount'] = $od_amount;

This will then allow this piece of code which already exists in the catalog/includes/modules/order_total/ot_subtotal.php file to work correctly:

    function process() {
      global $order, $currencies;

// BOF: LINES ADDED
      $od_amount = $_SESSION['od_amount'];
      $subtotal = $order->info['subtotal'] - $od_amount;
      $order->info['subtotal'] = $order->info['subtotal'] - $od_amount;
// EOF: LINES ADDED

Finally, change the sort order of the order total modules to put the Discount Coupons BEFORE the subtotal module, and everything will then work out. Here's how it looks in my store:



Now, I'm not a proficient PHP programmer, but there are sections of code that have the $_SESSION line commented out with a statement that says to use the global variable rather than the $_SESSION statement. So if there's a better, more preferred method of getting the $od_amount into the ot_subtotal routine, I would certainly welcome the tip.

John

Just follow these instructions...already there for you, no need to look elsewhere.

[BadDog]

Originally Posted by michael_s

Just follow these instructions...already there for you, no need to look elsewhere.

Well, that seems to work for discount coupons, but it does not work for gift certificates (at least not with ccgv(trad)), so I'm still looking for a solution for that piece.

[michael_s]

Maybe I am asking too much, but if it works in ot_coupon.php... why not make the logical connection that it should also work in ot_gv.php?

Here is the text file from the linkpoint mod:

Simple really, just had to figure out the "PHP" way to do it. Just a couple of edits so I won't include full files.

In /catalog/includes/modules/ot_coupon.php:

Find lines:

if ($od_amount > 0) {
$order->info['total'] = $order->info['total'] - $od_amount;

Add this line right after:

$_SESSION['od_amount'] = $od_amount;

In /catalog/includes/modules/ot_subtotal.php:

Find lines:

function process() {
global $order, $currencies;

Add right after:

$od_amount = $_SESSION['od_amount'];
$subtotal = $order->info['subtotal'] - $od_amount;
$order->info['subtotal'] = $order->info['subtotal'] - $od_amount;

Then, make sure the sort order of the payment lines (via OSCommerce admin
site) puts discount before subtotal.

Essentially, I just used the global PHP session to make the discount amount available in the standard subtotal routine. There may be more correct ways to do it but it works.

[BadDog]

Originally Posted by michael_s

Maybe I am asking too much, but if it works in ot_coupon.php... why not make the logical connection that it should also work in ot_gv.php?

Here is the text file from the linkpoint mod:

I added the line from ot_coupon.php to ot_gv.php but it did not work. Maybe there is a conflict between discount coupons and gift certificates? Maybe you can only use one or the other but not both? Hopefully someone who knows more about these than I do can shed some light on this.

[michael_s]

Did you put the gift voucher ot mod before the subtotal?