default_specials.php table problems

[miahac]

I am having problems with HTML syntax and rows ending in the default_specials.php file. I do not know if the problems are related.

It can be seen http://diecast-world.com/cat/

First. There seems to be no constraint keeping the products on special from being lined up side by side until the special products max value is reached. The other module below (NewProducts) clips at 3 products per row and goes to the next line.

Second. When I check the HTML output syntax there are many table elements that are not closed and start improperly (like rows containing no colums but containing other elements). These problems go away when I remove or comment the specials function.

2.0 RC1

[miahac]

Maybe this post should be moved to a different category?

[michael_s]

http://bugtrack.oscmax.com/view.php?id=46

[miahac]

Well i guess it was a bug but now there is still huge HTML errors and the listed fix does show 2 rows but now more tags (table and div) are not either closed or opened. Any suggestions. There are so many I cannot figure it out by copying the source and putting it in golive.

[miahac]

OK. I do not know if this is a complete fix but it sure cleaned up the HTML output. On line 65 of the "bugfixed" default_specials.php I took out the <td></td>

Mine now reads:

'text' => '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $specials[$x]['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $specials[$x]['products_image'], $specials[$x]['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a><br><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $specials[$x]['products_id']) . '">' . $specials[$x]['products_name'] . '</a><br><s>' . $currencies->display_price($specials[$x]['products_price'], tep_get_tax_rate($specials[$x]['products_tax_class_id'])) . '</s><br><span class="productSpecialPrice">' . $currencies->display_price($specials[$x]['specials_new_products_price'], tep_get_tax_rate($specials[$x]['products_tax_class_id'])));

I found this pretty quickly because there was <TD><TD> and </TD></TD>

Any thoughts?