Possible bug in Recover Cart Sales Email

[ridexbuilder]

There looks to be an issue with the email which is sent out to the customer.
Line 281 of catalog/admin/recover_cart_sales.php:

PHP Code:

        tep_mail('', $outEmailAddr, EMAIL_TEXT_SUBJECT, $email, '', STORE_OWNER . EMAIL_FROM); 


The Store Owner and email address are concatenated. Adding in a space helps but appears to cause issues with the customer when using "Reply To".
A workaround is to remove STORE_OWNER . (remember the trailing dot).
I'm sure there is a far better way.

[wkdwich]

Found another small issue with the catalog/admin/recover_cart_sales.php

the email to the customer shows:

Login to your account here: ( http://www.mysite.com/catalog/FILENAME_CATALOG_LOGIN)

Find:

if( EMAIL_USE_HTML == 'true' )
$email .= ' <a HREF="' . tep_catalog_href_link(FILENAME_CATALOG_LOGIN, '', 'SSL') . '">' . tep_catalog_href_link(FILENAME_CATALOG_LOGIN, '', 'SSL') . '</a>';
else
$email .= ' (' . tep_catalog_href_link(FILENAME_CATALOG_LOGIN, '', 'SSL') . ')';

REPLACE WITH:

 
if( EMAIL_USE_HTML == 'true' )
$email .= ' <a HREF="' . tep_catalog_href_link(FILENAME_LOGIN, '', 'SSL') . '">' . tep_catalog_href_link(FILENAME_LOGIN, '', 'SSL') . '</a>';
else
$email .= ' (' . tep_catalog_href_link(FILENAME_LOGIN, '', 'SSL') . ')';

[michael_s]

For the first issue, here is the fix to properly format the email header:

PHP Code:

tep_mail('', $outEmailAddr, EMAIL_TEXT_SUBJECT, $email, '', EMAIL_FROM); 


I tested it out and now works fine. This is also fixed in the upcoming 2.0.25 which I am now packaging up for release.

[ridexbuilder]

You changed it! Now the same as I have said above.
(Sorry, just found time to try your previous version - but it's gone! )

[michael_s]

The other code I posted did not work correctly, and was using the wrong constants.

The correct constant to use is EMAIL_FROM , and if that is properly set up there is no need to use the STORE_OWNER constant at all. I posted it again without the STORE_OWNER constant to avoid any confusion. This is what got committed to 2.0.25