Wishlist 3.5d

[kingsland]

I'm referring to a closed thread by auntie22. Wishlist 3.5d has the updates required in order to make the pre packaged oscmax 2.2 wishlist work(mod wishlist 2.4b) . The email is missing the product attribute part of the link. Even an email with the attribute as a word rather than a link would be fine.

A members answer was to use a compare tool to compare the old and new files. I'm using textpad and have spent the past 3 days trying to figure out what I need to include in the update 3.5d. 3.5d is built based on a non modified version. As you know OSCMAX is very modified, so trying to find out whats required and whats not required to update from the standard 2.4b is very difficult. Can someone help?

[jpf]

First of all Textpad may be a good editor - however like most text editors it is not a very good COMPARE TOOL. Look at WinMerge or UltraCompare or my fave - Beyond Compare.

These tools will visually show 2 directories and/or files side by side and show what is different in each (missing/extra/different lines and files).

Now the hard part - download your contrib and a fresh copy of OSC-MS2 and osCMax and unzip each into differnt directories. Compare the OSC-MS2 and the contrib directories (concentrates only on the contrib files) and clearly MARK the edited/changed/added lines with php or html comments. On the contrib side - add in any manual added code in the instructions and the file is not already supplied.

When done - Compare the now well document contribution and osCMax. Find the appropriate code in max and insert all your now commented edited/changed/added code. Take note of BTS notes that might be on the top part of the files - if you see a note about BTS - code might have been moved into file in the templates directory.

Careful of code already changed by MAX.

Good luck!

[kingsland]

I've installed beyond compare, admittedly it is 100% better at comparing files but it is proving very difficult to determine which code parts belong where, the bts has moved the contents from some of the files, so they do not compare well, I have spent the last 3 weeks making many unsuccessful attempts at updating the files in order to get wishlist to work properly on OSCMAX but to no avail. I'm going to have to retire on this one. Its just far too complicated an issue for a basic programmer like me. Sorry I would have liked to contribute to the oscmax project.


Thanks for the advice though

If anyone else gets wishlist functioning properly it would be appreciated.

[jpf]

True - but the ONE thing I do - is to compare/mark the contrib against a clean MS2 copy and mark ALL the changed/added code - if need be - mark old/removed code:

IE:

// old: Line of code listed here
Line of code modified listed here

The more comments/marking - the better it will be.

Next - compare the marked contrib to a clean osCMax - about 80% of the code will match up no problems - another up to 15% could be significantly changed/removed or moved into template files (there is a NOTE in the osCMax files that say so) - match anything that does then find the same name file (with .tmp.php file extension)in the template directory - (inside Beyond Compare) copy that over to the contribution - then right click the non-template file and select "Compare To..." then select the template file.

The LAST 5% is the headache parts - knowing BASIC SQL and programing helps. Compare it to what was changed from MS2 to MAX and MS2 to the contribution - Adding all three to come up with one will normally work - but some times cause problems - post code here if you need. Wish List should not be a hard one to do.

[jpf]

Here is a hacked version that is 98% done - with all current updates done - need testing.

Good Luck

[kingsland]

thanks for that. I'm going to start work on it from tomorrow, I'll post when I have it nearly completed. (probably take me a few weeks knowing my skills).

[jpf]

If it is 98% done (in 4 hours) - how can the last 2% take weeks?

[kingsland]

if your pessimistic, you'll never be disappointed. I'll get back soon

[jpf]

Good one!!!!