[osCmax v2.5x] osCmax 2.5 upgrade & SagePay module questions

[Munt]

Hi there folks, firstly thanks for the awesome software and forum support. You folks have been essential to the running of my online business.

I am currently sitting in a predicament, I have a functioning OSCmax 2.0.25 store here and I'm very excited at the possibility of upgrading to v2.5.

Currently in 2.0.25 I am having great difficulty getting payment modules to function correctly. Pay Pal direct and Sage Page Direct mainly. I see that support for paypal direct has been ported to v2.5 but I was hoping that support for SagePay would be built in too v2.5 is this possible?

I'm currently holding off doing any work to the site as I dont want to have to do it all again on the release of 2.5. Would I be mad to upgrade to 2.5 prior to its official release?

[pgmarshall]

Somewhere in the back of my mind I seem to remember SagePay not liking PayPal and visa versa ... If you look at the install instructions for SagePay there is a shift in the order module process which I think conflicts ... take a look through the instructions at osCommerce contributions.

I think this is why I held off installing this into the core of osCmax (more people use PayPal than SagePay)

Regards,

[michael_s]

I suggest you set up a test v2.5 store and see which features you need are not working yet in 2.5. Always a good idea before making the switch. Payment modules are usually very straightforward and easy to install so it should not be to terribly difficult to add. We only pre-install the ones that give people the most problems.

[pgmarshall]

Because I am nice I have had a look and this is the GitHub commit in question ... In the comments it says this will break PayPal etc

Hence why I have not installed it ... If someone else who is more familiar with PayPal than me can take a look that would help.

GitHub Changes

Regards,

[Munt]

I'll try out that PayPal Code edit tonight, thanks for getting back to me so soon.

Any ideas on how to fix the SagePay Direct payment loop (Diagnosing the shift in the order process is a bit beond my skills unfortunately)? I've tried intalling it to the letter and also a user contribution but unfortunately with no sucess.