[osCmax V2.0.25] "new products for %s" appears twice if no new products

[mraeryceos]

Bags & Can Liners : G and F Supply

I can't say I know where to look, considering that
<a class="headerNavigation"
does not appear anywhere in my code.

[mraeryceos]

If I take out the following line from new_products.php, both appearances of "new products for %s" disappear:
$box_content[] = array('align' => 'left', 'text' => '<a href="' . tep_href_link(FILENAME_PRODUCTS_NEW) . '" class="headerNavigation">' . sprintf(TABLE_HEADING_NEW_PRODUCTS, strftime('%B') . '</a>'));

The html output for the appearances are:

<td width="100%" height="14" class="infoBoxHeading"><a class="headerNavigation" href="http://gandfsupply.com/catalog/products_new.php">New Products For January</a></td>

<table width="100%" cellspacing="0" cellpadding="4" border="0" class="infoBoxContents">
<tbody><tr>
<td align="left"><a class="headerNavigation" href="http://gandfsupply.com/catalog/products_new.php">New Products For January</a></td>
</tr>
</tbody></table>

[ridexbuilder]

Suggest you look up the wiki for how to use BTS and template switching.
Then see if the fallback template exhibits the same issue.
We should have a dedicated page during install that says:

DO NOT MODIFY FALLBACK

Something to fall back on Synonyms, Something to fall back on Antonyms | Thesaurus.com
It may then sink in why it is called fallback.

[blackhawk]

Perhaps the fallback modification issue can be "dramatically" reduced by saying that on the download page for oscmax. "Make a renamed copy of fallback, but don't modify the original fallback directory." Also for ridexbuilder sake, so the man does not go out of his mind

[ridexbuilder]

Maybe need to be more subtle. Don't modify fallback, d'uh

[met00]

During installation...

it has a button that says

http://isg.theverybestdeal.com/dmf.php <<<<-------- click here for a very important message from the oscMax Development Team.

[ridexbuilder]

Poor mraeryceos
Comes here for a spot of advice and gets a from us zimmer posters.



[I know, I know, I started it. ]

[pgmarshall]

We could always hide it somewhere else! Perhaps, moving fallback back into the catalog root might stop people from fiddling with it.

Regards,

[mraeryceos]

The action happens in includes/classes/boxes.php

[mraeryceos]

At the top of includes/modules/new_products.php I replaced some code with:

  $products_new_query_raw = "select p.products_id, p.products_model, pd.products_name, p.products_image, p.products_price, p.products_tax_class_id, p.products_date_added, m.manufacturers_name from " . TABLE_PRODUCTS . " p left join " . TABLE_MANUFACTURERS . " m on (p.manufacturers_id = m.manufacturers_id), " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = pd.products_id and pd.language_id = '" . (int)$languages_id . "' and month(p.products_date_added) = month(now()) order by p.products_date_added DESC, pd.products_name";
  $products_new_split = new splitPageResults($products_new_query_raw, MAX_DISPLAY_PRODUCTS_NEW);
  $products_new_query = tep_db_query($products_new_split->sql_query);
  $no_of_products_new = tep_db_num_rows($products_new_query);
  if ($no_of_products_new > 0) {
     $boxy_content = '<a href="' . tep_href_link(FILENAME_PRODUCTS_NEW) . '" class="headerNavigation">' . sprintf(TABLE_HEADING_NEW_PRODUCTS, strftime('%B') . '</a>');
     echo '<img width="100%" height="10" border="0" alt="" src="images/pixel_trans.gif">' . $boxy_content;
  }

The trick was to have an array other than $box_content, because I think it gets used again further on.