Create account - password

[Dgriff]

I believe you have found a bug ...

Google code shows that in r351 the /* comment tags were removed from admin/create_account.php which will mean that the password fields are displayed.

Also in admin/create_account_process.php line 123 is commented out which is the bit that inserts the password you enter in the field at the bottom of the create account page.

If you want to use the password you enter then simply uncomment line 123 and 361 and comment out line 360.

If you want to use the auto-generated password then re-instate the /* and */ removed in r351 which enclosed the password section.

Can you report this as a bug in the BugTracker and I will fix soon.

The functionality probably should be that if you enter a password then it is used and sent to the client otherwise the system generates a random one for you and sends that.

Regards,

Hi
I want to use the auto generated password and I tried to find where to re-instate the /* and */ removed in r351 which enclosed the password section but I cant figure out where in admin/create_account.php I need to re-instate the /* and */ to. I downloaded previous versions to look a their admin/create_account.php to see what part was commented out to remove the password section but I couldn't see it. Any ideas? Thanks.

[pgmarshall]

The fix has been applied to the v2.1 code base here but for completeness ...

Replace: (at the bottom of admin/includes/modules/account_details.php)

<?php
  if (!$is_read_only) {
?>
  <tr>
    <td class="formAreaTitle"><br><?php echo CATEGORY_PASSWORD; ?></td>
  </tr>
  <tr>
    <td class="main"><table border="0" width="100%" cellspacing="0" cellpadding="2" class="formArea">
      <tr>
        <td class="main"><table border="0" cellspacing="0" cellpadding="2">
          <tr>
            <td class="main" width="170">&nbsp;<?php echo ENTRY_PASSWORD; ?></td>
            <td class="main">&nbsp;
<?php
    if ($error) {
      if ($entry_password_error) {
        echo tep_draw_password_field('password') . '&nbsp;' . ENTRY_PASSWORD_ERROR;
      } else {
        echo PASSWORD_HIDDEN . tep_draw_hidden_field('password') . tep_draw_hidden_field('confirmation');
      }
    } else {
      echo tep_draw_password_field('password') . '&nbsp;' . ENTRY_PASSWORD_TEXT;
    }
?></td>
         </tr>
<?php
    if ( (!$error) || ($entry_password_error) ) {
?>
          <tr>
            <td class="main" width="170">&nbsp;<?php echo ENTRY_PASSWORD_CONFIRMATION; ?></td>
            <td class="main">&nbsp;
<?php
      echo tep_draw_password_field('confirmation') . '&nbsp;' . ENTRY_PASSWORD_CONFIRMATION_TEXT;
?></td>
          </tr>
<?php
    }
?>

With:

<?php /*
  if (!$is_read_only) {
?>
  <tr>
    <td class="formAreaTitle"><br><?php echo CATEGORY_PASSWORD; ?></td>
  </tr>
  <tr>
    <td class="main"><table border="0" width="100%" cellspacing="0" cellpadding="2" class="formArea">
      <tr>
        <td class="main"><table border="0" cellspacing="0" cellpadding="2">
          <tr>
            <td class="main" width="170">&nbsp;<?php echo ENTRY_PASSWORD; ?></td>
            <td class="main">&nbsp;
<?php
    if ($error) {
      if ($entry_password_error) {
        echo tep_draw_password_field('password') . '&nbsp;' . ENTRY_PASSWORD_ERROR;
      } else {
        echo PASSWORD_HIDDEN . tep_draw_hidden_field('password') . tep_draw_hidden_field('confirmation');
      }
    } else {
      echo tep_draw_password_field('password') . '&nbsp;' . ENTRY_PASSWORD_TEXT;
    }
?></td>
         </tr>
<?php
    if ( (!$error) || ($entry_password_error) ) {
?>
          <tr>
            <td class="main" width="170">&nbsp;<?php echo ENTRY_PASSWORD_CONFIRMATION; ?></td>
            <td class="main">&nbsp;
<?php
      echo tep_draw_password_field('confirmation') . '&nbsp;' . ENTRY_PASSWORD_CONFIRMATION_TEXT;
?></td>
          </tr>
<?php
    }
?>
*/ ?>

Regards,