Sort order & Packing list by item number

[wkdwich]

This is driving me nuts.. I have searched here and at oscommerce.com and every fix I found returned an error.

I would like the Packing Slip at least or that and the Invoice to sort the products by product ID.. It would just make my life so much easier to pack the orders...

thanks

[blackhawk]

I may be wrong but its worth a shot! Look around line 83 in your classes/order.php file and see if it makes a difference to add

order by op.orders_products_id DESC

at the end of the sql query.

bh

[wkdwich]

Well I never thought to look there and I forgot to mention I am working with oscMax so my line numbers will be far different than the standard osc files.

$products = $cart->get_products();
for ($i=0, $n=sizeof($products); $i<$n; $i++) {
$this->products[$index] = array('qty' => $products[$i]['quantity'],
'name' => $products[$i]['name'],
'model' => $products[$i]['model'],
'tax' => tep_get_tax_rate($products[$i]['tax_class_id'], $tax_address['entry_country_id'], $tax_address['entry_zone_id']),
'tax_description' => tep_get_tax_description($products[$i]['tax_class_id'], $tax_address['entry_country_id'], $tax_address['entry_zone_id']),
'price' => $products[$i]['price'],
'final_price' => $products[$i]['price'] + $cart->attributes_price($products[$i]['id']),
'weight' => $products[$i]['weight'],
'id' => $products[$i]['id']);

there is no sort set on that section

this query further up does have a sort, but it is for the totals.

$totals_query = tep_db_query("select title, text from " . TABLE_ORDERS_TOTAL . " where orders_id = '" . (int)$order_id . "' order by sort_order");

So if it needs to get added to the 1st block of code I showed, where??? and how??

thanks

[blackhawk]

hmm... you should see a line in the file that says something like...

 $orders_products_query = tep_db_query("select op.orders_products_id, op.products_id, op.products_name....

Thats the line i was talking about.

[wkdwich]

OK got it.. admin/classes/order.php

$index = 0;
$orders_products_query = tep_db_query("
SELECT
op.orders_products_id,
op.products_name,
op.products_model,
op.products_price,
op.products_tax,
op.products_quantity,
op.final_price,
p.products_tax_class_id,
p.products_weight
FROM " . TABLE_ORDERS_PRODUCTS . " op
LEFT JOIN " . TABLE_PRODUCTS . " p
ON op.products_id = p.products_id
WHERE orders_id = '" . (int)$order_id . "'");

So before I mung it all up and shut my shop down .. I should change this to look like:

$index = 0;
$orders_products_query = tep_db_query("
SELECT
op.orders_products_id,
op.products_name,
op.products_model,
op.products_price,
op.products_tax,
op.products_quantity,
op.final_price,
p.products_tax_class_id,
p.products_weight
FROM " . TABLE_ORDERS_PRODUCTS . " op
LEFT JOIN " . TABLE_PRODUCTS . " p
ON op.products_id = p.products_id
WHERE orders_id = '" . (int)$order_id . "' .
order by op.orders_products_id DESC");

would that be correct?

[blackhawk]

that's exactly what i was talking about. see if it works for you.

[wkdwich]

Thanks for the help .

FROM " . TABLE_ORDERS_PRODUCTS . " op
LEFT JOIN " . TABLE_PRODUCTS . " p
ON op.products_id = p.products_id
WHERE orders_id = '" . (int)$order_id . "'
order by op.orders_products_id DESC");

had to adjust what I had above to this to not get anyy errors.. but no sorting is being done.. hahah wait it ordered it by the product ID not the item model.. so a little more playing around:

LEFT JOIN " . TABLE_PRODUCTS . " p
ON op.products_id = p.products_id
WHERE orders_id = '" . (int)$order_id . "'
order by op.products_model ASC");

and voila.. can't thank you enough..

[pgmarshall]

Don't forget to "Thank" people properly for their help!!

Click the in the bottom right hand corner of the message.


Regards,

[met00]

or the <img src=http://www.oscmax.com/forums/images/buttons/reputation.gif> on top of the message. Or if it was real real useful, both of them!