Can't send email in Recover Cart Sales 2.22

[ptt81]

Im using the stock OSCmax 2.2 with the built-in RCS 2.22, when I try to click send email under RCS report the page just seems to refresh and does nothing.

Then I found out that the email button actually link to /admin/recover_cart_sales.php which I believe the reason it reload the page instead of sending the email. Anyone know or have a fix for this?

[ridexbuilder]

Experiencing the same problem ('Max 2.0.3) , so having a Google...

[ridexbuilder]

It appears it may be to do with Register Globals.
From an oscommerce thread:

QUOTE (roxanacaz @ Oct 18 2007, 06:30 AM)
I found the solution! I added the code to define the function in admin/includes/functions/general.php - I took it from the Register Globals Patch contrib :

// >>> BEGIN REGISTER_GLOBALS
// Work-around functions to allow disabling of register_globals in php.ini
// These functions perform a similar operation as the 'link_session_variable'
// function added to .../functions/sessions.php but for the GET, POST, etc
// variables
//
// Parameters:
// var_name - Name of session variable
//
// Returns:
// None
function link_get_variable($var_name)
{
// Map global to GET variable
if (isset($_GET[$var_name]))
{
$GLOBALS[$var_name] =& $_GET[$var_name];
}
}

function link_post_variable($var_name)
{
// Map global to POST variable
if (isset($_POST[$var_name]))
{
$GLOBALS[$var_name] =& $_POST[$var_name];
}
}
// <<< END REGISTER_GLOBALS

I just hope I don't run into other problems...

Please comment on the validity of this (or possibly a better method )
Thanks.

[pgmarshall]

Been having a look at this one ...

I took the easiest route and have installed the lastest version from oscommerce - 2.30a (including the bug fix from pbor1234)

Easy install - although you will need to tailor the language file to put the content in the email.

Zip file here

Regards,

[ridexbuilder]

PGM took up the reins to make it work....Kudos (possibly).
Will check once I get a few moments...

[ridexbuilder]

Hurrah! It works.

Just for completion:

• I'd combine screenshot, sql, install (and configuration) files in a directory called docs/documents.
• Rename the resulting zip as Max_Recover_Cart_Sales_2.23, to differentiate from osC.

I see there's a weird thing going on with the link to the recipients' account but haven't read over the configuration stuff yet.
Just pleased to see that it's actually doing something and can now implement it/guide webshop owner on its' use.

Well done & thanks for picking up on this, PGM. Kudos approved.
Y'all show some appreciation with 'Thanks' to him, please.

[michael_s]

I have tested this on both v2.1 SVN and 2.0.3 and I have not come across the issue. When I send emails from RCS 2.22, they go out normally. I am running my tests on a server with register_globals off, so it may be some other issue.

More details about the issue you guys are having are in order. Server configs, check the error logs, etc. Post as much info as you can, so I can try to reproduce it.

[pgmarshall]

EJ,

The link to the recipients name searches the customers list for people with the same surname rather than trying to find an exact match ...

Not quite sure why ... maybe something to do with carts for people who are not logged in?

Regards

[ridexbuilder]

Nothing untoward really, Michael - 'straight' 2.0.3 svn 174
Installed in a a secondary subdomain i.e. max203.dev.xxxx.co.uk (I'm sure you can guess )
MySQL 5.0.81-community
5.2.9 (Zend: 2.2.0)
register_globals Off
Suhosin Extension 0.9.27


PGM:
Q: Why do my customer emails display FILENAME_CATALOG_LOGIN and/or FILENAME_CATALOG_PRODUCT_INFO?
A: These files need to be added to your configuration. Look at the installation directions in this document.

[JohnW]

EJ, There are some problems with constants not defined correctly in this and some other files.
Around 251 I changed

             $email .= '  <a HREF="' . tep_catalog_href_link(FILENAME_CATALOG_LOGIN, '', 'SSL') . '">' . tep_catalog_href_link(FILENAME_CATALOG_LOGIN, '', 'SSL')  . '</a>';
        else
            $email .= '  (' . tep_catalog_href_link(FILENAME_CATALOG_LOGIN, '', 'SSL') . ')'; 
  

to

       $email .= '  <a HREF="' . tep_catalog_href_link(FILENAME_LOGIN, '', 'SSL') . '">' . tep_catalog_href_link(FILENAME_LOGIN, '', 'SSL')  . '</a>';
    else
      $email .= '  (' . tep_catalog_href_link(FILENAME_LOGIN, '', 'SSL') . ')'; 
  

On a different note, after reading some info on php.net I changed line 306 and 315

<form method=post action=<?php echo $PHP_SELF; ?>> 

to

<form method=post action=<?php echo $_SERVER['PHP_SELF']; ?>> 

There is another instance of echo $PHP_SELF in the recover carts mod too. Basically, I searched my site for this and found 4 in total but I think the other may have been a mod that's not part of max. Either way it's an easy search to find it.