php5 question+oscmax rc3

[bkpie]

My host is switching soon to php5 and mysql5 I have read about people having problems and having to switch have register globals on in php.ini or fixing it in the .htaccess file. The posts I read were with oscmax RC2. I use RC3 is this still an issue with that release? or should it be fine when they make the switch.

Thanks in advance

[bkpie]

I put this contribution on my test site super easy and it states it will work with globals on or off, php 4 or 5 and won't break any modules like shipping or credit. It seems to work on my local machine test site but I can not verify on my local machine if it does not affect the shipping or credit modules. Has anyone used this on a live site yet? Thank you in advance.

osCommerce Community Add-Ons

[freitas66]

I still have problems with Oscmax 2.0 RC3 and PHP 5.
Does anyone knows when the final version will come throw?

[bkpie]

Don;t think anyone around Freitas66 I know I tried the above contribution register globals easy and I thought it worked but it breaks the saved cart. If a customer logs out they lose the cart. CRAP!

[michael_s]

I have no problems with php5. See this thread:
Testers needed for register_globals/register_long_arrays=off

[bkpie]

Michael:

I have seen that thread. Did you install the changes mentioned in that thread? I know that I still get an error with RC3 on the local machine using xampp and php4 or 5 but not live using php 4. I am just trying to avert problems that may occur when the host switches next week. Also in that thread no one mentioned whether they tested the ups xml shipping module. Thanks

[michael_s]

It could be a setting on your local machine causing the issue. I have no errors when adding the magic-seo solution, including no problems with saved carts.

[bkpie]

Nope I just made the changes and put it on my live site. Even though the customers saved cart is still in the database it does not show when they re login. Once I put the code back to what it was the cart shows back up when logging in. I am be-fuddled if that is a word and frustrated. Could it be a setting I have in the admin or another contribution that was installed?

[bkpie]

Alright I narrowed it down to the changes causing this for my shop is in catalog/includes/functions/sessions .php If I do all the contributions changes except for this file it works and the saved cart shows back up. So now if anyone can tell me why?
I am still going crazy. If it worked in Michaels install why not mine.
Argggg

[bkpie]

OK I have narrowed it down to the piece of code in the contribution at around line 112 of catalog/includes/functions/sessions that makes my store not be able to see the saved cart. Here is the exact contribution code for register globals easy that messes me up by not letting customers see saved cart when they re login

function tep_session_is_registered($variable) {
if(isset($_SESSION[$variable])) {
return true;
} else {
return false;
}
}


Here below is the original code in that section it replaced that worked

function tep_session_is_registered($variable) {
return session_is_registered($variable);
}


Is this enough detail to get the answer from someone who might know a bit more php than I?