TIP allprods.tpl.php modification

[JohnW]

I'm not sure if anyone else has run into this problem but the stock Allprods mod that is in RC 3.01 combined with SEO URLs not sure about stock (but definitely updated to 2.1+) was giving me problems. The problem may be a combination of these items running on Apache 2.+ because the rewrite is different but I think this was an issue before. Either way, Google flags the problem urls as problems so I want Google happy.

The major problem is it was causing the address to be rewritten with the product name details twice. Googlebot doesn't like this and under Google's web tools it was listing this as a problem. On top of that it was being rewritten badly. Here is an example of how I wanted it
Dried Flowers R Us : Case - Curly Willow - Natural - 15 bunches - $89.94
and this is what I was getting
Dried Flowers R Us : Case - Curly Willow - Natural - 15 bunches - $89.94
which looks the same but if you click on the link it's a mess. I'm not sure how to get this to display the problem here but put your mouse over it or click it and you'll see.
This is a problem on many levels but the fix is really simple. Here it is

in templates/fallback/content/allprods.tpl.php look around line 44 for this code
note: vbulletin is changing the code I'm pasting in this box

echo "     <a href=\"" . tep_href_link(FILENAME_PRODUCT_INFO, 'name=' .str_replace("/", "/", rawurlencode($this_products_name)). '&products_id=' . $this_products_id . (($this_language_code == DEFAULT_LANGUAGE) ? '' : ('&language=' . $this_language_code)), 'NONSSL', false) . "\">" . $this_products_name . "</a><br>\n";

and replace it with this

echo "     <a href=\"" . tep_href_link(FILENAME_PRODUCT_INFO, 'name=' . '&products_id=' . $this_products_id . (($this_language_code == DEFAULT_LANGUAGE) ? '' : ('&language=' . $this_language_code)), 'NONSSL', false) . "\">" . $this_products_name . "</a><br>\n";

Basically, this code is removed
note: vbulletin is changing the code I'm pasting in this box

str_replace("/", "/", rawurlencode($this_products_name)).

So, has anyone run into this problem besides me?