Small bug on /includes/functions/general.php function tep_mail ?

[MindTwist]

Trying to fix one of the several non-critical issues I still have on my OSCMAX, I noticed that when people email a question through /contact_us.php, they enter their name, email, and question, but on the email I was receiving their name was nowhere to be found.

From contact_us.php we are doing a:
tep_mail(STORE_OWNER, STORE_OWNER_EMAIL_ADDRESS, EMAIL_SUBJECT, $enquiry, $name, $email_address);

And here the $name is passed right.

On /includes/funtions/general.php, on lines 1078-1080 we have:
----------
$to_name = preg_replace('/[\n|\r].*/', '', $to_name);
$email_subject = preg_replace('/[\n|\r].*/', '', $email_subject);
$from_email_name = preg_replace('/[\n|\r].*/', '', $from_name);
----------

Shouldn't this last line be "$from_email_name = preg_replace('/[\n|\r].*/', '', $from_email_name);" ? I changed that $from_name to $from_email_name and now the emails I receive through contact_us.php are showing up with the correct from, like "name <email@something.com>" instead of just "<email@something.com"

[michael_s]

You are correct. This bug has already been reported in the bugtracker and has already been fixed in the development repository. You should check the bugtracker to keep current with all reported issues.

210: Incorrect variable reference in tep_mail() causing missing sender's name in outgoing email - Bug Tracker - open source Commerce Maximized :: osCMax

[MindTwist]

Oooops... nevermind my post then.
When I started installing my OSCMAX store I download the latest version available for download on http://www.oscmax.com/project/osCMax , which I guess must be the same there is now, 2.0.0-RC3-0-1 from 2/Jan/2007, didn't know at the time I could download a development version or otherwise I might have done that.

[michael_s]

There is no dev package, but if you have an SVN client you can check out the latest source code from the repository.

oscmax2 - Google Code

[MindTwist]

Too late for me, but thanks anyway... I have already configured/tweaked/installed too much to do it again from scratch.
I had already browsed the bug tracker a couple weeks ago and applied the patches to the bugs that affected me, I guess that I either didn't go far enough in time, or that I just missed this one.

[michael_s]

Its never too late! That is the great thing about SVN, you can simply compare your existing code to the SVN code and just add in the changes.