Problem with Gift Voucher/Coupon Email Sent to Customer

[michael_s]

99.9% of all problems are caused by using the Search Engine safe urls option. It should ALWAYS be turned off. It has not been correctly implemented in the core code, and it breaks just about everything...

[stewj1]

Thanks for the info on the Search Engine safe urls option, I didn't know that. I just turned it off and replaced the files I edited (admin/gv_mail, catalog/gv_send) and the Admin Send Gift Voucher Link emailed to the customer is now correct, but the Send Gift Voucher out of the cart still has the osCsid attached to the link

https://host246.ipowerweb.com/~categ...8230ae2bb&osCsid=39eba15bf78535607330830ab699def6

Any ideas why? When using this link, it goes back to the session that was used when it was created if the user has not logged off yet. I'm sure it would eventually/hopefully expire, but the customer is already logged in as me, if I haven't logged off yet. And after testing, if I log off the user does have to login, and it is then under their account, but still with the same osCid, in this case 39eba15bf78535607330830ab699def6, weird, but in the admin/gv_mail it is done differently, and works fine without adding a osCid to the end. Please let me know if you also see a osCid in the email sent from the "Send Gift Voucher" portion of the store.

[michael_s]

Try putting this in your .htaccess file:

php_flag session.use_trans_sid off

Then close your browser, open a new instance, visit your admin and try sending again. That may solve the issue.

I am also going to take a look at the files in question.

[stewj1]

The admin portion is now working fine, the only issue I had with that with friendly URL's was the link was sent incorrectly. The store "Send Gift Voucher" is the one that is sending the osCsid with the e-mail, is there anyway of turning off the osCsid in the store?

Thanks

[michael_s]

Yes, add the following to your .htaccess file in your public_html dir, as I suggested and let me know if it works:

php_flag session.use_trans_sid off

[stewj1]

Sorry about the confusion, I thought you mean't the .htaccess file in my admin directory. I made the change in my .htaccess on my public_html file, and I'm still having the problem.

https://host246.ipowerweb.com/~categ...a2c37174a&osCsid=8e5a19c5d568ced39077587fd8598778

This is the code in the gv_send.php that is causing the problem:

$gv_email .= EMAIL_GV_LINK . tep_href_link(FILENAME_GV_REDEEM, 'gv_no=' . $id1);;

I used the code from the admin/gv_mail.php:

message .= HTTP_SERVER . DIR_WS_CATALOG . 'gv_redeem.php' . '?gv_no='.$id1 . "\n\n";

and it is now sending the correct link to the customer.

https://host246.ipowerweb.com/~categ..._no=32d71a40e6

I don't know if this is just an issue with my site, or not, but that worked for me. Let me know if you see any issues with this. Thanks...

[michael_s]

I'm glad you have it sorted out finally.

I ran a test through the demo shop with the original code that you were having trouble with (appending session id) and it does not happen on the demo shop. I can only guess as to why this is. It can be many different things from session settings in osCommerce to session settings in php.ini.

Hopefully your diligence in tracking this down will help others who run across this issue.

[malcol27]

The author says that he used a line of code from the admin/gv_mail.php but does not say if he replaced a part of the original text or a part of the text or just included the new code in the existing /catalog/gv_send.php. Can one of the admins or the author of this post please clarify a bit more? Im having the same problem and the variations I've tried aren't eliminating the osCsid in the customer sent Gift Voucher Emails.

Thanks!

[malcol27]

I tried a few more things and the fix mentioned above does work, the exact code change is below.

change this:

$gv_email .= EMAIL_GV_LINK . tep_href_link(FILENAME_GV_REDEEM, 'gv_no=' . $id1);;

to this

$gv_email .= HTTP_SERVER . DIR_WS_CATALOG . 'gv_redeem.php' . '?gv_no='.$id1 . "\n\n";

that second snippet (as the previous post explains) comes from the admin/gv_mail.php file which is used to send gift vouchers from the admin panel.