Tried it out - looks good - some minor points...

1.) Durring install - MySql import - ask for OSCOMMERCE.SQL but needs MS2-MAX.SQL

2.) Default CATALOG\CONFIGURE.PHP is populated with AABOX.COM setting - including database password (don't know if this is a vaild PW or not).

Also:

Default SSL should be False - not eveyone has SSL. You have : define('ENABLE_SSL', true);

define('DIR_FS_CATALOG', dirname($HTTP_SERVER_VARS['SCRIPT_FILENAME']));
you have:
define('DIR_FS_CATALOG', '/home2/aaboxco/public_html/ms2/catalog/');

This causes problems with download files as not eveyone is /home2/aaboxco....ect....

3.) Default ADMIN\CONFIGURE.PHP is populated with AABOX.COM setting - including database password (don't know if this is a vaild PW or not).

Also:
Missing ID line - older version?? - latest is 1.14 from 2/21/2003

Default SSL should be False - not eveyone has SSL. You have : define('ENABLE_SSL', true);


4.) /admin/include/fuctions/compatabilty.php - you have 1.10 - latest is 1.11 - your missing a new fuction that was added 7/18/03

5.) /admin/include/graphs/banner_infobox.php is v 1.4 2003/07/30 - you have 1.3 -
typo in $graph->SetTitle(TEXT_BANNERS_LAST_3_DAYS);

6.) /admin/includes/languages/english/file_manager.php is v 1.14 2003/07/21 - you have 1.13 -
? Moved out one define fuction to below???

7.) /admin/includes/languages/english.php is v 1.107 2003/07/21 - you have 1.106 -
? Moved in one define fuction from above???
define('ERROR_FILE_NOT_REMOVEABLE', 'Error: I can not remove this file. Please set the right user permissions on: %s');

8.) /admin/define_language.php is v 1.16 2003/07/30 - you have 1.15 -
Small change for muilt-laug.


9.) /catalog/includes/boxes/categories.php v 1.25 2003/07/09 - you have 1.24
This is acutally 1.25!!!! multi laug.

10.) /catalog/includes/classes/order_total.php FILE ID IS WRONG! Said it is 1.3.2.7 and really is 1.4

11.) Add Auto Copywrite to footer! (Only a suggestion - not hard to do)

12.) /catalog/includes/modules/payment/ipayment.php v 1.33 2003/07/19 you have 1.32 - one small change

13.) /catalog/includes/modules/payment/pm2checkout.php,v 1.20 2003/07/19 you have 1.19 - one small change

14.) "WYSIWYG HTMLArea MS2 v1.7" with "Define mainpage" not included in ZIP file under /oscommerce-2.2ms2/contributions/ please add!


Other than that - still have the same problem saving DEFINE MAINPAGE though HTMLArea. Must be my test server.

Till then- JPF

[michael_s]

Thank you for the excellent feedback. Yeah, looks like I missed a few things with the many rebuilds that I have done. Look for updates shortly:

I double checked the archive, and let me go through here to confirm:

1. This is set to correctly retieive ms2-max.sql in the zip file, so not sure why you are having trouble. Just to check, I ran a test install, and it worked with no problem, so I'm not sure what the trouble is for you.

Default SSL should be False

You actually set this when you run the installer. The settings in the archive should get overwritten when you run the installer. Regardless, I have changed it to false.

define('DIR_FS_CATALOG', '/home2/aaboxco/public_html/ms2/catalog/');

Again will be overwritten when you run the installer. I removed it, as it shouldnt be there.

Default ADMIN\CONFIGURE.PHP is populated with AABOX.COM setting - including database password (don't know if this is a vaild PW or not).

This will get overwritten when you run the installer. But it should not be there. Has been removed. The PW is not valid.

Missing ID line - older version?? - latest is 1.14 from 2/21/2003

This is the default MS2 download, not the CVS. I used the base MS2 release, not the CVS tree. If there have been changes to the default MS2 release, they happened after I dl'd this one. If the version you speak of is from CVS, that is why its not in here. I will look into the changes. I have not touched any of the ID lines.

Points 4-13 on the file versions, again if it is CVS you are referring to, Im not using it. I have not chagned any of the file versions, if they are wrong, they were wrong in the original osC package.

14. Added.

I will look at the version updates for the listed files later today, and incorporate them if they have been included in the MS2 package (not the CVS).

Thank you for the detailed feedback! It makes it much easier to fix things

Originally Posted by msasek

Thank you for the excellent feedback. Yeah, looks like I missed a few things with the many rebuilds that I have done. Look for updates shortly:

I double checked the archive, and let me go through here to confirm:

1. This is set to correctly retieive ms2-max.sql in the zip file, so not sure why you are having trouble. Just to check, I ran a test install, and it worked with no problem, so I'm not sure what the trouble is for you.

Actually it import fine - it said it will import "oscommece.sql" and that installing on IIS that I have to place the file in "c:\install\" which I did - but it said cannot find "ms2-max.sql" so I place it there and worked fine now.

You actually set this when you run the installer. The settings in the archive should get overwritten when you run the installer. Regardless, I have changed it to false.

I also did a manual install and as well compaired to a current version of MS2 CVS.

Default ADMIN\CONFIGURE.PHP is populated with AABOX.COM setting - including database password (don't know if this is a vaild PW or not).

This will get overwritten when you run the installer. But it should not be there. Has been removed. The PW is not valid.

Thank Good ness.

[/quote]
Thank you for the detailed feedback! It makes it much easier to fix things [/quote]

As noted there is a few BUG fixes in the CVS to the MS2 package.

All is stable now. No major commits lately.


Have you tried Contribution Control & Bookmark MOD - very handy to keep track of all these mods.

If you want I could SQL dump my database so you don't have to populate it your self.

[/quote]