Option Type and 051112 Patch

[TracyG]

Hi,
I am getting a parse error that indicates the last line of /includes/classes/shopping_cart.php

This problem is related to applying the 051112 security patch to that file, which has been modified for the Option Type feature text option.

Code can be viewd at
http://mykeepsakebooks.com/catalog/s...rt_opt_sec.txt

I am sure it is just an extra or lacking } or something.

Tracy

[michael_s]

What is the exact error message please...

[TracyG]

Sorry Michael, I was in a rush when I posted. Here it is:

Parse error: parse error, unexpected $ in /home/httpd/vhosts/mykeepsakebooks.com/httpdocs/catalog/includes/classes/shopping_cart.php on line 596

Tracy

[michael_s]

It looks like you were missing a couple of closing braces as you suspected.

If you add a closing brace after the following lines (in 2 places):

Line 157:

                if (tep_session_is_registered('customer_id')) tep_db_query("insert into " . TABLE_CUSTOMERS_BASKET_ATTRIBUTES . " (customers_id, products_id, products_options_id, products_options_value_id, products_options_value_text) values ('" . (int)$customer_id . "', '" . tep_db_input($products_id_string) . "', '" . (int)$option . "', '" . (int)$value . "', '" . tep_db_input($attr_value) . "')");

Add another closing brace } just below it (there is already one there, so create a new line and add the extra one).


Then just after line 224:

            if (tep_session_is_registered('customer_id')) tep_db_query("update " . TABLE_CUSTOMERS_BASKET_ATTRIBUTES . " set products_options_value_id = '" . (int)$value . "', products_options_value_text = '" . tep_db_input($attr_value) . "' where customers_id = '" . (int)$customer_id . "' and products_id = '" . tep_db_input($products_id_string) . "' and products_options_id = '" . (int)$option . "'");

Add another closing brace, just like the first one. That should fix it for you.

[TracyG]

Thanks, Michael,
This corrected the error, but the TEXT options value is not being passed to the shopping cart from the form, and if the order continues to the end the TEXT fields are blank.

I will look over at the oscommerce forums for the contribution, while I await any comments you might have.

Here is my shopping_cart.php with new brackets added.

http://mykeepsakebooks.com/catalog/s...pt_sec.php.txt

Thanks,
Tracy

[TracyG]

Additional info.

These are lines 256 & 257 of /checkout_process.php

                            // 'products_options_values' => $attributes_values['products_options_values_name'], 
                                'products_options_values' => $order->products[$i]['attributes'][$j]['value'],

If I use the second line with the secured /includes/classes/shopping_cart.php, I get blanks in the TEXT field. If I use the first line, I get "TEXT" in the TEXT field.

Still investigating. I am going to check through everything and make sure I made all the changes correctly.

In the meantime, the store is working with the 1.7 store version of the /includes/classes/shopping_cart.php and checkout_process.php files, as a bandaid.

Thanks,
Tracy

[michael_s]

Check the thread for this mod over at oscommerce.com, as the TEXT appearing instead of the actual input is a common issue that is resolved in that thread...

[TracyG]

Thanks Michael

[jillbalkus]

Hi! I'm having the same problem, and when I tried Michael's solution, it didn't work.

I'm getting a parse error on my catalog/includes/classes/shopping_cart.php page after adding the Option Type contribution 1.7.2:

Parse error: parse error, unexpected ';', expecting T_OLD_FUNCTION or T_FUNCTION or T_VAR or '}' in .../html/catalog/includes/classes/shopping_cart.php on line 867

Here's the code: http://keepsakeprograms.com/shopping_cart.txt

Perhaps my braces are also off?