Gift Voucher: Customer Email problems. Please help!

[malcol27]

Im using v 1.70 and when I send a gift voucher using the admin section, the customer receives an Email that looks like this

The Gift Voucher is worth 150kr

To redeem this Gift Voucher, please click on the link below. Please also write down the redemption codewhich is43f3ec in case you have any problems.

http://www.sitex.sehttp://sitex.se/b...p?gv_no=43f3ec

or visit http://www.sitex.sehttp://sitex.se/bk/catalog/ and enter the code during the checkout process

What can I do to have the URL with the gift certificate appear only one time, so it looks like this in the customer email? The link as configured above will not work and I can't figure out how to change it!

http://sitex.se/bk/catalog/gv_redeem.php?gv_no=43f3ec

http://sitex.se/bk/catalog/

I have turned off search engine friendly URLs and tried to change gv_mail.php, but nothing seems to work... here is what I think is the relevant part of gv_mail.php.

$message .= TEXT_TO_REDEEM;
$message .= TEXT_WHICH_IS . $id1 . TEXT_IN_CASE . "\n\n";
if (SEARCH_ENGINE_FRIENDLY_URLS == 'true') {
$message .= HTTP_SERVER . DIR_WS_CATALOG . 'gv_redeem.php' . '/gv_no,'.$id1 . "\n\n";
} else {
$message .= HTTP_SERVER . DIR_WS_CATALOG . 'gv_redeem.php' . '?gv_no='.$id1 . "\n\n";
}
$message .= TEXT_OR_VISIT . HTTP_SERVER . DIR_WS_CATALOG . TEXT_ENTER_CODE;

Help if you can, I've run out of ideas!

[michael_s]

That looks like a problem with your configure.php or the /admin/includes/configure.php. The above code is building the url with:

HTTP_SERVER . DIR_WS_CATALOG

Try checking the above entries in your configure.php files to make sure the are correct. You can also try editing the TEXT_OR_VISIT text in the file /admin//includes/languages/english/gv_mail.php

[malcol27]

Your help is very appreciated... so here are the results so far.

Well I've tried every variation I can think of using the variables you mentioned along with changing paths in my two config.php files. I had been doing the same thing all day, so it was good to get confirmation that I was in the right place.... but I've still got the same problem. The Email shows two links pressed together and to top it off, the customer Gift Voucher is sending the osCsid along with the gift voucher link and I can't figure out how to get that to stop... but first problem first. Here is my admin.

*
osCommerce, Open Source E-Commerce Solutions
http://www.oscommerce.com

Copyright (c) 2003 osCommerce

Released under the GNU General Public License
*/

// Define the webserver and path parameters
// * DIR_FS_* = Filesystem directories (local/physical)
// * DIR_WS_* = Webserver directories (virtual/URL)
define('HTTP_SERVER','http://www.serverx.se');
// eg, http://localhost - should not be empty for productive servers
define('HTTP_CATALOG_SERVER','http://www.serverx.se');
define('HTTPS_CATALOG_SERVER','https://serverx.se');
define('ENABLE_SSL_CATALOG', 'false'); // secure webserver for catalog module
define('HTTP_COOKIE_PATH', '/catalog/');
define('HTTPS_COOKIE_PATH', '/catalog/');
define('DIR_WS_HTTP_CATALOG', '/catalog/');
define('DIR_WS_HTTPS_CATALOG', '/catalog/');
define('DIR_FS_DOCUMENT_ROOT','/home/newserver/public_html/serverx/bk/catalog/'); // where the pages are located on the server
define('DIR_WS_ADMIN', '/bk/catalog/admin/');
// absolute path required
define ('DIR_FS_ADMIN','/home/newserver/public_html/serverx/bk/catalog/admin/'); // absolute pate required
define('DIR_WS_CATALOG', 'http://serverx.se/bk/catalog/');
// absolute path required
define('DIR_FS_CATALOG','/home/newserver/public_html/serverx/bk/catalog/'); // absolute path required
define('DIR_WS_IMAGES', 'images/');
define('DIR_WS_ICONS', DIR_WS_IMAGES . 'icons/');
define('DIR_WS_CATALOG_IMAGES', DIR_WS_CATALOG . 'images/');
define('DIR_WS_INCLUDES', 'includes/');
define('DIR_WS_BOXES', DIR_WS_INCLUDES . 'boxes/');
define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES . 'functions/');
define('DIR_WS_CLASSES', DIR_WS_INCLUDES . 'classes/');
define('DIR_WS_MODULES', DIR_WS_INCLUDES . 'modules/');
define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES . 'languages/');
define('DIR_WS_CATALOG_LANGUAGES', DIR_WS_CATALOG . 'includes/languages/');
define('DIR_FS_CATALOG_LANGUAGES', DIR_FS_CATALOG . 'includes/languages/');
define('DIR_FS_CATALOG_IMAGES', DIR_FS_CATALOG . 'images/');
define('DIR_FS_CATALOG_MODULES', DIR_FS_CATALOG . 'includes/modules/');
define('DIR_FS_BACKUP', DIR_FS_ADMIN . 'backups/');

and here is my bk/catalog/includes/configure.php

<?php
/*
osCommerce, Open Source E-Commerce Solutions
http://www.oscommerce.com

Copyright (c) 2003 osCommerce

Released under the GNU General Public License
*/

// Define the webserver and path parameters
// * DIR_FS_* = Filesystem directories (local/physical)
// * DIR_WS_* = Webserver directories (virtual/URL)
define('HTTP_SERVER','http://www.serverx.se'); // eg, http://localhost - should not be empty for productive servers
define('HTTPS_SERVER','https://www.serverx.se'); // eg, https://localhost - should not be empty for productive servers
define('ENABLE_SSL', false); // secure webserver for checkout procedure?
define('HTTP_COOKIE_DOMAIN','serverx.se');
define('HTTPS_COOKIE_DOMAIN','https://serverx.se');
define('HTTP_COOKIE_PATH','/bk/catalog/');
define('HTTPS_COOKIE_PATH','/bk/catalog/');
define('DIR_WS_HTTP_CATALOG','/bk/catalog/');
define('DIR_WS_HTTPS_CATALOG','/bk/catalog/');
define('DIR_WS_IMAGES','images/');
define('DIR_WS_ICONS',DIR_WS_IMAGES ,'icons/');
define('DIR_WS_INCLUDES','includes/');
define('DIR_WS_BOXES', DIR_WS_INCLUDES . 'boxes/');
define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES . 'functions/');
define('DIR_WS_CLASSES', DIR_WS_INCLUDES . 'classes/');
define('DIR_WS_MODULES', DIR_WS_INCLUDES . 'modules/');
define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES . 'languages/');

define('DIR_WS_DOWNLOAD_PUBLIC', 'pub/');
define('DIR_FS_CATALOG','/home/newserver/public_html/serverx/bk/catalog/');
define('DIR_FS_DOWNLOAD', DIR_FS_CATALOG . 'download/');
define('DIR_FS_DOWNLOAD_PUBLIC', DIR_FS_CATALOG . 'pub/');


I have intentionally left out the bottom section referencing database hookup, but I am currently using mysql to save sessions and we have not installed any https... I have to turn in for the night (European time) before my head explodes from looking at these files all day, but I will check back tomorrow! Thank You

[michael_s]

The session id in your email is a separate issue. Here is a thread that should resolve that for you:

http://oscdox.com/index.php?name=PNp...r&start=15


Looking at your configure.php files, you are using the wrong file for your admin configure.php. It just looks like a copy of the catalog configure.php, which is incorrect. You need to restore the original configure.php file that comes with osCMax as the one you are using is completely wrong. It has stuff that shouldn't be in there and is missing stuff that should.

Here is a sample of a default admin configure.php file:

<?php
/*
  osCommerce, Open Source E-Commerce Solutions
  http://www.oscommerce.com

  Copyright (c) 2003 osCommerce

  Released under the GNU General Public License
*/

// Define the webserver and path parameters
// * DIR_FS_* = Filesystem directories (local/physical)
// * DIR_WS_* = Webserver directories (virtual/URL)
  define('HTTP_SERVER', ''); // eg, http://localhost - should not be empty for productive servers
  define('HTTP_CATALOG_SERVER', '');
  define('HTTPS_CATALOG_SERVER', '');
  define('ENABLE_SSL_CATALOG', 'false'); // secure webserver for catalog module
  define('DIR_FS_DOCUMENT_ROOT', ''); // where the pages are located on the server
  define('DIR_WS_ADMIN', ''); // absolute path required
  define('DIR_FS_ADMIN', ''); // absolute pate required
  define('DIR_WS_CATALOG', ''); // absolute path required
  define('DIR_FS_CATALOG', ''); // absolute path required
  define('DIR_WS_IMAGES', 'images/');
  define('DIR_WS_ICONS', DIR_WS_IMAGES . 'icons/');
  define('DIR_WS_CATALOG_IMAGES', DIR_WS_CATALOG . 'images/');
  define('DIR_WS_INCLUDES', 'includes/');
  define('DIR_WS_BOXES', DIR_WS_INCLUDES . 'boxes/');
  define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES . 'functions/');
  define('DIR_WS_CLASSES', DIR_WS_INCLUDES . 'classes/');
  define('DIR_WS_MODULES', DIR_WS_INCLUDES . 'modules/');
  define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES . 'languages/');
  define('DIR_WS_CATALOG_LANGUAGES', DIR_WS_CATALOG . 'includes/languages/');
  define('DIR_FS_CATALOG_LANGUAGES', DIR_FS_CATALOG . 'includes/languages/');
  define('DIR_FS_CATALOG_IMAGES', DIR_FS_CATALOG . 'images/');
  define('DIR_FS_CATALOG_MODULES', DIR_FS_CATALOG . 'includes/modules/');
  define('DIR_FS_BACKUP', DIR_FS_ADMIN . 'backups/');

// define our database connection
  define('DB_SERVER', ''); // eg, localhost - should not be empty for productive servers
  define('DB_SERVER_USERNAME', '');
  define('DB_SERVER_PASSWORD', '');
  define('DB_DATABASE', '');
  define('USE_PCONNECT', 'false'); // use persisstent connections?
  define('STORE_SESSIONS', ''); // leave empty '' for default handler or set to 'mysql'
?>

As you can see, your file is all wrong as far as the defines go. Start over with this above file, adding your paths to it.

[red_fraggle]

this line in your admin/includes/configure.php

define('DIR_FS_DOCUMENT_ROOT','/home/newserver/public_html/serverx/bk/catalog/');

should actually be this

define('DIR_FS_DOCUMENT_ROOT','/home/newserver/public_html/serverx/bk/');

[malcol27]

I've updated the /admin/includes/configure.php using the file above but I've still got the same results. I also tried to send a gift voucher from our test server, which is local vs. the server where the problem was discovered, which is hosted and I get the same result. So Im wondering how can I add some spaces inbetween the various URLs that are listed, which would at least make the link functional in the Email (there will also be alot of unecessary links, but unless there is another answer,I'll just live with that)

Here is the admin/gv_mail.php. I see the area where the links are parsed into the Email, but Im not sure how to get them to have a few spaces separating them so the URL does not run together.

Edited by admin - no need to post all that code. Not needed for a fix


Thanks!

[malcol27]

Here is the new version, based on the file you provided...after thinking about it, I thought you might want to see the results of your recommendation and verify that I haven't screwed up something else !

<?php
/* 
  osCommerce, Open Source E-Commerce Solutions 
  http://www.oscommerce.com 

  Copyright (c) 2003 osCommerce 

  Released under the GNU General Public License 
*/ 

// Define the webserver and path parameters 
// * DIR_FS_* = Filesystem directories (local/physical) 
// * DIR_WS_* = Webserver directories (virtual/URL) 
  define('HTTP_SERVER', 'http://www.serverx.se'); // eg, http://localhost - should not be empty for productive servers
  define('HTTP_CATALOG_SERVER', 'http://www.serverx.se');
  define('HTTPS_CATALOG_SERVER', 'https://serverx.se');
  define('ENABLE_SSL_CATALOG', 'false'); // secure webserver for catalog module 
  define('DIR_FS_DOCUMENT_ROOT', '/home/newserver/public_html/serverx/bk/'); // where the pages are located on the server
  define('DIR_WS_ADMIN', '/bk/catalog/admin/'); // absolute path required
  define('DIR_FS_ADMIN', '/home/newserver/public_html/serverx/bk/catalog/admin/'); // absolute pate required
  define('DIR_WS_CATALOG', 'http://serverx.se/bk/catalog'); // absolute path required
  define('DIR_FS_CATALOG', '/home/newserver/public_html/serverx/bk/catalog/'); // absolute path required
  define('DIR_WS_IMAGES', 'images/'); 
  define('DIR_WS_ICONS', DIR_WS_IMAGES . 'icons/'); 
  define('DIR_WS_CATALOG_IMAGES', DIR_WS_CATALOG . 'images/'); 
  define('DIR_WS_INCLUDES', 'includes/'); 
  define('DIR_WS_BOXES', DIR_WS_INCLUDES . 'boxes/'); 
  define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES . 'functions/'); 
  define('DIR_WS_CLASSES', DIR_WS_INCLUDES . 'classes/'); 
  define('DIR_WS_MODULES', DIR_WS_INCLUDES . 'modules/'); 
  define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES . 'languages/'); 
  define('DIR_WS_CATALOG_LANGUAGES', DIR_WS_CATALOG . 'includes/languages/'); 
  define('DIR_FS_CATALOG_LANGUAGES', DIR_FS_CATALOG . 'includes/languages/'); 
  define('DIR_FS_CATALOG_IMAGES', DIR_FS_CATALOG . 'images/'); 
  define('DIR_FS_CATALOG_MODULES', DIR_FS_CATALOG . 'includes/modules/'); 
  define('DIR_FS_BACKUP', DIR_FS_ADMIN . 'backups/');

[red_fraggle]

both of these are also wrong

define('HTTP_CATALOG_SERVER', 'http://www.serverx.se'); 
define('HTTPS_CATALOG_SERVER', 'https://serverx.se');

they should be

define('HTTP_CATALOG_SERVER', 'http://www.serverx.se/bk/catalog'); 
define('HTTPS_CATALOG_SERVER', 'https://serverx.se/bk/catalog');

[michael_s]

This may also work for you:

<?php 
/* 
osCommerce, Open Source E-Commerce Solutions 
http://www.oscommerce.com 

Copyright (c) 2003 osCommerce 

Released under the GNU General Public License 
*/ 

// Define the webserver and path parameters 
// * DIR_FS_* = Filesystem directories (local/physical) 
// * DIR_WS_* = Webserver directories (virtual/URL) 
define('HTTP_SERVER', 'http://www.serverx.se/bk'); // eg, http://localhost - should not be empty for productive servers 
define('HTTP_CATALOG_SERVER', 'http://www.serverx.se/bk'); 
define('HTTPS_CATALOG_SERVER', 'https://serverx.se/bk'); 
define('ENABLE_SSL_CATALOG', 'false'); // secure webserver for catalog module 
define('DIR_FS_DOCUMENT_ROOT', '/home/newserver/public_html/serverx/bk/'); // where the pages are located on the server 
define('DIR_WS_ADMIN', '/catalog/admin/'); // absolute path required 
define('DIR_FS_ADMIN', '/home/newserver/public_html/serverx/bk/catalog/admin/'); // absolute pate required 
define('DIR_WS_CATALOG', '/catalog'); // absolute path required 
define('DIR_FS_CATALOG', '/home/newserver/public_html/serverx/bk/catalog/'); // absolute path required 
define('DIR_WS_IMAGES', 'images/'); 
define('DIR_WS_ICONS', DIR_WS_IMAGES . 'icons/'); 
define('DIR_WS_CATALOG_IMAGES', DIR_WS_CATALOG . 'images/'); 
define('DIR_WS_INCLUDES', 'includes/'); 
define('DIR_WS_BOXES', DIR_WS_INCLUDES . 'boxes/'); 
define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES . 'functions/'); 
define('DIR_WS_CLASSES', DIR_WS_INCLUDES . 'classes/'); 
define('DIR_WS_MODULES', DIR_WS_INCLUDES . 'modules/'); 
define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES . 'languages/'); 
define('DIR_WS_CATALOG_LANGUAGES', DIR_WS_CATALOG . 'includes/languages/'); 
define('DIR_FS_CATALOG_LANGUAGES', DIR_FS_CATALOG . 'includes/languages/'); 
define('DIR_FS_CATALOG_IMAGES', DIR_FS_CATALOG . 'images/'); 
define('DIR_FS_CATALOG_MODULES', DIR_FS_CATALOG . 'includes/modules/'); 
define('DIR_FS_BACKUP', DIR_FS_ADMIN . 'backups/');

The 4 lines that I changed are:

define('HTTP_SERVER', 'http://www.serverx.se/bk'); // eg, http://localhost - should not be empty for productive servers 
define('HTTP_CATALOG_SERVER', 'http://www.serverx.se/bk'); 
define('HTTPS_CATALOG_SERVER', 'https://serverx.se/bk'); 

define('DIR_WS_CATALOG', '/catalog'); // absolute path required 
define

The one that was causing the double url in the email is the last one, DIR_WS_CATALOG, that should be a path, not a url. Also notice that DIR_WS_CATALOG was also incorrect in your first config files that you posted...

[malcol27]

With your excellent help (THANKS!) things started to clear up. I took the last changes you both gave and tweaked them just a bit... now its smooth sailing. The final code is shown below

[/code]define('HTTP_SERVER', 'http://www.serverx.se'); // eg, http://localhost - should not be empty for productive servers
define('HTTP_CATALOG_SERVER', 'http://www.serverx.se/bk/catalog');
define('HTTPS_CATALOG_SERVER', 'https://serverx.se/bk/catalog');

define('DIR_WS_CATALOG', '/bk/catalog/'); // absolute path required
define

the last one DIR_WS_CATALOG was a little tricky to sort out, but it was a good lesson on absolute paths. Thanks again !