Email from the admin?

[Kristine]

oh yes, and thanks for your help Neil I do appreciate it.

[neil]

From one of your other posts you said you were using MIME email format.
If you haven't altered any files in that admin_21.zip that could be the "issue".

There may be something addressing that if the author has updated this contrib over at Oscommerce contributions or something in the contribs discussion over there.

[Kristine]

no, MIME is set to false, I think it always has been.
Is there any need to alter those files since it was already installed in MAX? It's funny that all the other emails are correct (new customer and order notices)

[neil]

No need to alter those files for the admin users.
To check if they have not been altered you could try comparing the originals with what you have.
textpad has a "compare" feature. A bit tedious doing it one by one but that would tell if they are different.

new customer and order notices are handled by different files included in the "stock standard" OSC.
admin_21 is a major contribution.

If you have access to more than 1 database you could install another standard Max in another directory and test your admin emails. If you still have problems then it is a server issue - email tech support of your server.

[Kristine]

I found the problem, thanks to someone from the osc board. I had to do the following:

Reviewing the files of this contribution and its README, it appears that both admin_account.php and admin_members.php compose an email using the function sprintf and ADMIN_EMAIL_TEXT. The language file for admin_members.php does indeed have a define for ADMIN_EMAIL_TEXT, but the language file for admin_account.php does not.

So, I would copy the define from admin_members.php into admin_account.php since it is missing, then see what happens.

It works just dandy now!!
Maybe someone should update that in the next download of MAX?

[neil]

Excellent that you have worked it out & strange that it works without the "missing define" on some servers & not on others. Maybe the version of PHP?

I had the same problem as well, and the same solution worked. FYI.

[Sandwich]

Erk, didn't notice I wasn't logged in. Sorry.

[kodersoftware]

Thanks Kristine! This helped me too and I hope it gets fixed in the next releases.

To be specific, I added the following lines to /admin/languages/english/admin_account.php:

/* originally, these lines were missing.
 * added by jim
 * found fix at http://oscdox.com/index.php?name=PNphpBB2&file=viewtopic&t=2456&highlight=adminemailtext
 * (note: changed the wording a little since these are used for admin password resetting)
 */
define('ADMIN_EMAIL_SUBJECT', 'Admin Account Edit Complete');
define('ADMIN_EMAIL_TEXT', 'Hi %s,' . "\n\n" . 'You Your account has been editted.  Your new account login credentials are supplied below.' . "\n\n" . 'Website : %s' . "\n" . 'Username: %s' . "\n" . 'Password: %s' . "\n\n");

I changed line 54 in /admin/admin_account.php from

tep_mail($HTTP_POST_VARS['admin_firstname'] . ' ' . $HTTP_POST_VARS['admin_lastname'], $HTTP_POST_VARS['admin_email_address'], ADMIN_EMAIL_SUBJECT, sprintf(ADMIN_EMAIL_TEXT, $HTTP_POST_VARS['admin_firstname'], HTTP_SERVER . DIR_WS_ADMIN, $HTTP_POST_VARS['admin_email_address'], $hiddenPassword, STORE_OWNER), STORE_OWNER, STORE_OWNER_EMAIL_ADDRESS);

to

tep_mail($HTTP_POST_VARS['admin_firstname'] . ' ' . $HTTP_POST_VARS['admin_lastname'], $HTTP_POST_VARS['admin_email_address'], ADMIN_EMAIL_SUBJECT, sprintf(ADMIN_EMAIL_TEXT, $HTTP_POST_VARS['admin_firstname'], HTTP_SERVER . DIR_WS_ADMIN, $HTTP_POST_VARS['admin_email_address'], $HTTP_POST_VARS['admin_password']), STORE_OWNER, STORE_OWNER_EMAIL_ADDRESS);

(this removes the store name from the email because the admins probably know that already. it also uses the $HTTP_POST_VARS['admin_password'] instead of $hiddenPassword because $hiddenPassword doesn't exist in the admin_account.php script)

-Jim