osCMax v2.0.15 Pre-Release

[srq]

Ridex -

In regards to Bug 341, I thought that r315 was the latest package available for testing. Where do I get r333?

In regards to Bug 336 - I did read the notes in the bug report and I will have to disagree that it is correct behavior. The reason is:
When someone adds a Gift Voucher to shopping cart and stops short of paying for it, the gift card is getting added to the Queue list with no indication that it is not paid for. There is no easy way for the store manager to identify that a Gift Voucher in the queue list is not paid for. Maybe there should be a status tag shown in the queue list that indicates the Voucher in the list is not paid for. Also, if the Voucher never gets paid for, there should be a mechanism in the admin to manually remove/delete the unpaid voucher from the queue list. (Yes/No?)

[srq]

In regards to Bug 341 - I applied the fixes in r333 to my current r315 install.

Now, When I buy a gift voucher with Paypal IPN, it is properly getting added to the Queue List (which was not before). However, the Order ID in the Queue List is always 0 (zero) so there is no way to cross reference an item in the queue list with a customer order.

[michael_s]

Ridex -

In regards to Bug 341, I thought that r315 was the latest package available for testing. Where do I get r333?

You don't unless you know how to use SVN. Doesn't matter anymore - get the full release as it is now available.

In regards to Bug 336 - I did read the notes in the bug report and I will have to disagree that it is correct behavior. The reason is:
When someone adds a Gift Voucher to shopping cart and stops short of paying for it, the gift card is getting added to the Queue list with no indication that it is not paid for. There is no easy way for the store manager to identify that a Gift Voucher in the queue list is not paid for. Maybe there should be a status tag shown in the queue list that indicates the Voucher in the list is not paid for. Also, if the Voucher never gets paid for, there should be a mechanism in the admin to manually remove/delete the unpaid voucher from the queue list. (Yes/No?)

It is the correct behavior. There is absolutely no other way to do it. It has to be pre-populated into the database before you go to paypal, otherwise there will never be a record and nothing for paypal to confirm via IPN.

That is why the paypal module has two order status settings. Set it to "Paypal Pending" for all un-confirmed paypal orders, this is how you get an "Indication that it is not paid for." Configure it to "Confirmed" or "Delivered" only upon receiving the IPN confirmation from paypal. This is why the paypal modules have the multiple order status settings.

In regards to Bug 341 - I applied the fixes in r333 to my current r315 install.

Now, When I buy a gift voucher with Paypal IPN, it is properly getting added to the Queue List (which was not before). However, the Order ID in the Queue List is always 0 (zero) so there is no way to cross reference an item in the queue list with a customer order.

You are right, it is still showing as zero. See below for the fix. This will be added to the next maintenance release:

---------------------------------------------------------------------------------
-- [Version] 0.0.1.alpha [/Version]
-- CCGV 5.19 Fix for GV Queue with Paypal IPN
-- mailto:code@creativeportal.ca
-- CreativePortal.ca - A Host of New Ideas written by Chris Bensler
---------------------------------------------------------------------------------

Fixes an issue when a customer buys a gift voucher and pays with paypal, the order_id stored in the coupon_gv_queue table is always 0.

The problem is that the order id that is being stored is referencing a global, but the call is nested in the paypal payment class
so $insert_id is not in the global scope.

The fix is to update all definitions of the update_credit_acount method to accept a second $order_id param.
All calls to update_credit_account($i) should also be replaced with update_credit_acount($i,$insert_id).

---------------------------------------------------------------------------------
MOD INSTRUCTIONS:

---------------------------------------------------------
in includes/modules/order_total/ot_gv.php
---------------------------------------------------------
Replace:
function update_credit_account($i) {
global $order, $customer_id, $insert_id, $REMOTE_ADDR;
With:
function update_credit_account($i, $order_id=0) {
global $order, $customer_id, $insert_id, $REMOTE_ADDR;
if (!$order_id) $order_id = $insert_id;

---------------------------------------------------------
Replace $insert_id with $order_id in:
$gv_insert=tep_db_query("insert into " . TABLE_COUPON_GV_QUEUE . " (customer_id, order_id, amount, date_created, ipaddr) values ('" . $customer_id . "', '" . $insert_id . "', '" . $gv_order_amount . "', NOW(), '" . $REMOTE_ADDR . "')");

---------------------------------------------------------
in includes/modules/order_total/ot_coupon.php
---------------------------------------------------------
Replace:
function update_credit_account($i) {
With:
function update_credit_account($i, $order_id=0) {

---------------------------------------------------------
in includes/classes/order_total.php
---------------------------------------------------------
Replace:
function update_credit_account($i) {
With:
function update_credit_account($i, $order_id=0) {

---------------------------------------------------------
Replace:
$GLOBALS[$class]->update_credit_account($i);
With:
$GLOBALS[$class]->update_credit_account($i, $order_id);

---------------------------------------------------------
in checkout_process.php
**NOTE** this mod is not needed but for conformity
---------------------------------------------------------
Replace:
$order_total_modules->update_credit_account($i);//ICW ADDED FOR CREDIT CLASS SYSTEM
With:
$order_total_modules->update_credit_account($i,$insert_id);//ICW ADDED FOR CREDIT CLASS SYSTEM

---------------------------------------------------------
in includes/modules/payment/gv_paypal_ipn.php
**NOTE** if you use another paypal ipn module, you must apply this fix similarly
---------------------------------------------------------
Replace:
$order_total_modules->update_credit_account($i);//ICW ADDED FOR CREDIT CLASS SYSTEM
With:
$order_total_modules->update_credit_account($i,$insert_id);//ICW ADDED FOR CREDIT CLASS SYSTEM

[srq]

That is why the paypal module has two order status settings. Set it to "Paypal Pending" for all un-confirmed paypal orders, this is how you get an "Indication that it is not paid for." Configure it to "Confirmed" or "Delivered" only upon receiving the IPN confirmation from paypal. This is why the paypal modules have the multiple order status settings.

Michael - I think we have a communication problem. I think you are talking about "order" table and why we need to populate it before we go to Paypal... I absolutely agree that you need to pre-populate the DB before going to Paypal...

I am talking specifically about the Gift Voucher Queue list that corresponds to "coupon_gv_queue" table in the database. The Voucher Queue list is the place holder that when someone buys a GV, the store administrator can release the GV to the buyer ....

Now, when store customer adds a GV to shopping cart using Paypal Standard and stops short of going to Paypal and paying for it, the Gift Voucher is already added to the Gift Voucher Queue list as seen in admin. When the store owner goes to the admin-Vouhcer Queue List, he/she will see the gift voucher in the list. Note: Looking at the "Gift Voucher Queue" list, there is no way for the store owner to tell that the gift voucher is paid for or not.

The problem described above makes the GV module when using Paypal Standard unusable.

To fix the problem, I suggest to put some status tag in the coupon voucher queue list/table that indicates whether a GV is paid or not.

Also, if a GV remains unpaid, there should be a mechanism in the admin user interface to remove or delete a gift voucher from the list or corresponding table entry.

[srq]

You are right, it is still showing as zero. See below for the fix. This will be added to the next maintenance release

I am very appreciative for all the work but am sad that the oscMax team did not address all the pending GV Paypal issues in this release. I waited so long to have the GV & Paypal issues fixed out of the box in a released version of oscMax. That is why I was doing my own testing on pre-release version of 2.0.15 ...

Right now, I continue to have several oscMax sites with non functional/disabled Gift Voucher/Paypal program.

[ridexbuilder]

It is free and open source software and supported for free in peoples' spare time (in some cases). You are more than welcome to make the effort to resolve issues for yourself and distribute the solution to the community.

A potential fix has been offered; why not try it and if it works, package it up as a patch/contribution to 'Max?

P.S.
I am sad that I couldn't find the brain cells/time/inclination/incentive to get Option Type Feature working yet.
Also, having had spent some time on Wolfen Feature Sets, I discover that I should be looking at Open Feature Sets.
Priorities....

[michael_s]

Michael - I think we have a communication problem.

I fully understand what you are talking about. It is simply not as big an issue as you make it out to be, as it is very easy to tell whether or not a voucher has been paid or not.

Every voucher purchase is tied to an order whether or not the customer pays it. So, if you look at your new orders first (which is how you would even know you had a voucher order) you will note on that page whether or not it has been paid for, and who the person is that ordered it. If it has been paid, you simply go to the voucher queue, find their name and release it.

I agree with you, there are still some issues to work out, but they fall short of making the GV queue unusable.

As a side note, the 2.0.15 released yesterday does now populate the order ID with the gift voucher (but it also populates two vouchers, so yes, there are still some issues).

We will be addressing the remaining issues in the next maintenance release in a few weeks. In the mean time, I will probably address this issue in the bugtracker before then.

[michael_s]

I am very appreciative for all the work but am sad that the oscMax team did not address all the pending GV Paypal issues in this release. I waited so long to have the GV & Paypal issues fixed out of the box in a released version of oscMax. That is why I was doing my own testing on pre-release version of 2.0.15 ...

Right now, I continue to have several oscMax sites with non functional/disabled Gift Voucher/Paypal program.

We addressed every issue related to CCGV in the bugtracker and resolved all but a couple of minor issues that were not reported in time to fix by the release date. Those are coming in the next maintenance release.

FYI, The GV Queue is now populated with the order ID on every GV order done by paypal or paypal IPN.

The remaining issues are minor and do not make the GV system unusable. They will be addressed, but we felt it more important to release on time, and get to the remaining minor issues in the next maintenance release.

[srq]

It is free and open source software and supported for free in peoples' spare time (in some cases). You are more than welcome to make the effort to resolve issues for yourself and distribute the solution to the community.

I understand the concept of free open source s/w, but I am not a level of php programmer yet where I can distribute code changes. My contribution to this community thus far has been to find potential bugs and report them with hopes that someone more knowledgeable with the code can fix it...

if you look at your new orders first (which is how you would even know you had a voucher order) you will note on that page whether or not it has been paid for, and who the person is that ordered it. If it has been paid, you simply go to the voucher queue, find their name and release it.

Suggestion: Maybe we can add the the functionality of releasing a GV right in the Customer->Orders page under admin. Put a button in the order line item if the product is a Gift Voucher in order to release that GV. This will make for a more user freindly interface... Another suggestion is to add an extra Boolean field in the "coupon_gv_queue" table (Paid=Yes/No). When you first add a GV to this table before going to Paypal, mark this field as (NO). After you return from Paypal & if payment is verified, change this field to (YES)

Also, there still remains the issue of removing unpaid gift voucher from the Queue list. Suggest to add a "Delete" button on the GV Queue List admin interface to remove unpaind vouchers from the list.