Security Pro

[michael_s]

Tougher security.php

Included is a tougher catalog/includes/functions/security.php

The changes are minimal but it makes a big difference. The rest of the package remains the same.

Changes:
% character removed
$get_var is urldecoded before the preg_replace strips bad characters.

No changes are required of the contribution just directly replace catalog/includes/functions/security.php

Please note: Unlike other contributions, this one will break more things the better it gets.

Odd sounding I know but it is the case. Now that this is urldecoding and is missing the % character a lot more scripts, payment modules etc will fail .. this is a GOOD thing. By all means exclude your broken payment module from cleansing by security Pro .. however, I wouldn't advise doing the same for a less important contribution .. why not see where it's stopped by this script and change it so that it doesn't use bad characters in the querystring.

Most important: Test fully your important systems after adding this . .especially payment/shipping etc.

As usual I need feedback.

Thanks to perfectpassion for continuing to help me test this alongside his PROTX payment module (which I use myself by the way).


Please try to think along the following lines:-

If Security Pro breaks a feature/function

1) Try to remove the need for the feature to use bad characters (Stay here as long as possible)

2) Exclude the file from cleansing only if you really have to. (Should only be critical operations like payment)

3) NEVER alter the preg_replace or other functions in security.php unless improving it (making it tougher).
In the case of this contribution "Yaaay I got it to work by removing X in security.php!" = you broke your security.

More...