PDA

View Full Version : [Admin Issue] OSCMAX 2.5 order comments



Pr0ject
02-24-2012, 02:09 PM
I usually update my customer through the order editor by updating orders from pending -> processing -> Shipped -> delivered and by checking the notify customer box the system should email them. However, Now I've been leaving notify customer clicked and when the screen gets updated it says X and the customer is not notified.

Pr0ject
02-24-2012, 02:18 PM
Just to clarify the comments are sent if I am using the "edit" orders on the very right but if I just double click to bring the order up, it is not working.

pgmarshall
02-24-2012, 02:49 PM
Sorry Pr0ject - can you explain what this issue again ... I am a bit lost on what the problem is ... are the customers being emailed? Or is it an issue with edit orders?

Regards.

Pr0ject
02-24-2012, 03:05 PM
orders.php?page=1&oID=2111&action=edit <- that url I cannot notify the customer of the comments i have made to the order by email
edit_orders.php?oID=2104 <- that url I can notify the customer no problem

pgmarshall
02-25-2012, 12:03 AM
Both of these pages have the ability to notify the customer ... are you telling me that one of them does not work when you use it? Or that you don't know how to do it?

Without detailed info I can not help much more!

Regards.

michael_s
02-25-2012, 09:52 AM
PGM,

I have the same issue. The problem is this, on orders_php when I update the order status and/or add a comment and have "notify customer" checked, no emails go out and the Customer Notified icon is always a red X no matter what.

I tailed the mail server logs while executing this and no email is ever generated.


It works fine on "edit_orders.php"

This problem is present on a default 2.5.0 installation.

michael_s
02-25-2012, 10:41 AM
Yikes! I'll take the blame for this one. It appears r1628 (my commit!) broke this feature. I am going through the changes to find what I screwed up now.

michael_s
02-25-2012, 11:16 AM
It was the over-invasive Google Checkout mod again. That mod moved the email function/notify update status into the included file. When we made it conditional, when not enabled the email building routine was missing from the orders.php.

I have fixed the issue and it will be in v2.5.1. I will write up a proper bug report later today.

ridexbuilder
02-25-2012, 03:18 PM
At least you found it!
It's the primary reason for me staying clear of these payment modules that worm their way into the core code.

michael_s
02-25-2012, 04:36 PM
I think I have wrested back core control from the GC module. It is no longer running its code even though it is disabled. We can now work on improving it when it is actually enabled.

I knew it had to be one of my changes, so it was pretty easy to find. Silly really, but I had forgotten that whomever coded the GC mod was a bit heavy handed with the Google-Centered-Universe mentality.

Pr0ject
02-27-2012, 08:32 AM
Thanks Michael!

Pr0ject
02-27-2012, 03:49 PM
hmm seems like when I uncheck the notify checkbox it still notifies the customer.

michael_s
02-29-2012, 11:45 AM
Thanks for being patient. I have made a second commit today that fully fixes the issue. Just a few lines needed tweaking.

pr0ject, I added the fix to your store already. Your checkboxes are working again.

Pr0ject
02-29-2012, 12:11 PM
awesome Michael! thank you!

technophobe
02-29-2012, 10:21 PM
Good to know you are working on a fix for this.
when it is done can you post it here?

Pr0ject
02-29-2012, 11:01 PM
its in the bug tracker... 0001124: admin orders.php "Notify Customer" does not work - osCmax Bug Tracking System (http://bugtrack.oscmax.com/view.php?id=1124)

michael_s
03-01-2012, 08:17 AM
Yeah, already fixed. You can get the changes from the repository link that Pr0ject posted.

It will be in 2.5.1 point release at the end of March too.